RE: [PATCH v4 2/3] libbpf: Fix the incorrect register read for syscalls on x86_64

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: RE: [PATCH v4 2/3] libbpf: Fix the incorrect register read for syscalls on x86_64
From: <Kenta.Tada@xxxxxxxx>
Date: Thu, 20 Jan 2022 22:56:15 +0000
Accept-language: ja-JP, en-US
Cc: <andrii@xxxxxxxxxx>, <bpf@xxxxxxxxxxxxxxx>, <ast@xxxxxxxxxx>, <daniel@xxxxxxxxxxxxx>, <kafai@xxxxxx>, <songliubraving@xxxxxx>, <yhs@xxxxxx>, <john.fastabend@xxxxxxxxx>, <kpsingh@xxxxxxxxxx>
In-reply-to: <CAEf4Bza9A+iC49bZRiSPWNuy+=qG3sc=_XvKem4Fj2zZF8merg@mail.gmail.com>
Thread-index: AQHYDTZZ2C28qVTfhEWPJ0gTzKPfeqxqq8iAgAHYINA=
Thread-topic: [PATCH v4 2/3] libbpf: Fix the incorrect register read for syscalls on x86_64

>did you check PT_REGS_PARM4_CORE() definition? This should be

In my local test, this wrong code can pass the correct arg4 because the test just checks the value.
Anyway I should attach the test for CORE variants at first.
Sorry. I'll fix the issues and add tests for CORE variants this weekend.

Follow-Ups:
- Re: [PATCH v4 2/3] libbpf: Fix the incorrect register read for syscalls on x86_64
  - From: Andrii Nakryiko

References:
- [PATCH v4 0/3] Fix the incorrect register read for syscalls on x86_64
  - From: Kenta Tada
- [PATCH v4 2/3] libbpf: Fix the incorrect register read for syscalls on x86_64
  - From: Kenta Tada
- Re: [PATCH v4 2/3] libbpf: Fix the incorrect register read for syscalls on x86_64
  - From: Andrii Nakryiko

Prev by Date: Re: [PATCH v5 bpf-next 3/3] selftests/bpf: Add test for sleepable bpf iterator programs
Next by Date: Re: [PATCH bpf-next v4 0/2] perf: stop using deprecated bpf APIs
Previous by thread: Re: [PATCH v4 2/3] libbpf: Fix the incorrect register read for syscalls on x86_64
Next by thread: Re: [PATCH v4 2/3] libbpf: Fix the incorrect register read for syscalls on x86_64
Index(es):
- Date
- Thread

[Index of Archives] [Linux Samsung SoC] [Linux Rockchip SoC] [Linux Actions SoC] [Linux for Synopsys ARC Processors] [Linux NFS] [Linux NILFS] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI]