On Wed, Dec 15, 2021 at 11:22 AM Christy Lee <christylee@xxxxxx> wrote:
>
> Backtracking information is very verbose, don't print it in log
> level 1 to improve readability.
>
> Signed-off-by: Christy Lee <christylee@xxxxxx>
> ---
LGTM.
Acked-by: Andrii Nakryiko <andrii@xxxxxxxxxx>
> kernel/bpf/verifier.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> index a8f1426b0367..2cb86972ed35 100644
> --- a/kernel/bpf/verifier.c
> +++ b/kernel/bpf/verifier.c
> @@ -2398,7 +2398,7 @@ static int backtrack_insn(struct bpf_verifier_env *env, int idx,
>
> if (insn->code == 0)
> return 0;
> - if (env->log.level & BPF_LOG_LEVEL) {
> + if (env->log.level & BPF_LOG_LEVEL2) {
> verbose(env, "regs=%x stack=%llx before ", *reg_mask, *stack_mask);
> verbose(env, "%d: ", idx);
> print_bpf_insn(&cbs, insn, env->allow_ptr_leaks);
> @@ -2656,7 +2656,7 @@ static int __mark_chain_precision(struct bpf_verifier_env *env, int regno,
> DECLARE_BITMAP(mask, 64);
> u32 history = st->jmp_history_cnt;
>
> - if (env->log.level & BPF_LOG_LEVEL)
> + if (env->log.level & BPF_LOG_LEVEL2)
> verbose(env, "last_idx %d first_idx %d\n", last_idx, first_idx);
> for (i = last_idx;;) {
> if (skip_first) {
> @@ -2743,7 +2743,7 @@ static int __mark_chain_precision(struct bpf_verifier_env *env, int regno,
> new_marks = true;
> reg->precise = true;
> }
> - if (env->log.level & BPF_LOG_LEVEL) {
> + if (env->log.level & BPF_LOG_LEVEL2) {
> mark_verifier_state_scratched(env);
> verbose(env, "parent %s regs=%x stack=%llx marks:",
> new_marks ? "didn't have" : "already had",
> --
> 2.30.2
>
