On Tue, 14 Dec 2021 07:04:35 -0800 Jakub Kicinski wrote: > > My understanding that patch 4 is the key. > > I think the bpf-link.h bpf-cgroup-types.h and bpf-cgroup-storage.h > > are too specific. We don't do a header file per type. > > Maybe combine them all into one bpf-cgroup-types.h ? > > That will still achieve the separation of cgroup from linux/bpf.h The dependency tree is bpf-link.h bpf-cgroup-types.h ^ ^ | / bpf.h bpf-cgroup.h ^ ^ | | | | bpf-cgroup-storage.h I can't merge bpf-cgroup-storage.h with the rest, it'd be a loop. Should I leave that one be separate? Any other ideas?