On Mon, 13 Dec 2021 21:15:06 -0800 Alexei Starovoitov wrote: > On Mon, Dec 13, 2021 at 3:42 PM Jakub Kicinski <kuba@xxxxxxxxxx> wrote: > > > > struct bpf_link needs to be embedded by cgroups. > > Put it in its own header. > > > > Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx> > > --- > > include/linux/bpf-link.h | 23 +++++++++++++++++++++++ > > include/linux/bpf.h | 10 +--------- > > 2 files changed, 24 insertions(+), 9 deletions(-) > > create mode 100644 include/linux/bpf-link.h > > > > diff --git a/include/linux/bpf-link.h b/include/linux/bpf-link.h > > new file mode 100644 > > index 000000000000..d20f049af51a > > --- /dev/null > > +++ b/include/linux/bpf-link.h > > @@ -0,0 +1,23 @@ > > +/* SPDX-License-Identifier: GPL-2.0-only */ > > +/* Copyright (c) 2011-2014 PLUMgrid, http://plumgrid.com > > + */ > > +#ifndef _LINUX_BPF_MIN_H > > +#define _LINUX_BPF_MIN_H 1 > > MIN_H ? Used to stand for "minimal", forgot to rename after I changed course. > My understanding that patch 4 is the key. > I think the bpf-link.h bpf-cgroup-types.h and bpf-cgroup-storage.h > are too specific. We don't do a header file per type. > Maybe combine them all into one bpf-cgroup-types.h ? > That will still achieve the separation of cgroup from linux/bpf.h
