> "This patch is a part ([0]) of libbpf-1.0 milestone. > > [0] Closes: https://github.com/libbpf/libbpf/issue/383 > > Please update in the next revision. Sure, will send in a V2 of the patch. > > > Also, keep in mind that we ask to use "[PATCH bpf-next]" prefix when > submitting patches against the bpf-next kernel tree. It makes the > intent clear and our BPF CI system knows which tree to test against. > Thanks. > Apologies, duly noted for subsequent patches. > I'd say it's still a good idea for explicitness and to show that we > didn't forget about it :) Plus, if it actually ever fails, we don't > want to WRITE_ONCE() here, so please follow the same error handling > logic as it was previously with parse_cpu_mask_file. > > > > > WRITE_ONCE(cpus, tmp_cpus); > > return tmp_cpus; Sure, will adhere to the coding style. Thank you for your reivew. -mfrw
