Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx> writes: > On Mon, Aug 2, 2021 at 6:04 PM Ederson de Souza > <ederson.desouza@xxxxxxxxx> wrote: >> >> Two new pairs of helpers: `xsk_umem__adjust_prod_data` and >> `xsk_umem__adjust_prod_data_meta` for data that is being produced by the >> application - such as data that will be sent; and >> `xsk_umem__adjust_cons_data` and `xsk_umem__adjust_cons_data_meta`, >> for data being consumed - such as data obtained from the completion >> queue. >> >> Those function should usually be used on data obtained via >> `xsk_umem__get_data`. Didn't change this function to avoid API breaks. >> >> Signed-off-by: Ederson de Souza <ederson.desouza@xxxxxxxxx> >> --- > > AF_XDP parts of libbpf are being moved into libxdp ([0]). We shouldn't > keep adding new APIs if we are actively working on deprecating and > removing existing functionality already. CC'ing Toke and Magnus for > the state of libxsk to libxdp migration. > > [0] > https://github.com/xdp-project/xdp-tools/tree/master/lib/libxdp#using-af_xdp-sockets The AF_XDP code is merged into libxdp and is fully functional with the exception of Maciej's XDP program auto-detach feature which we need to replicate in a different way in libxdp. So as far as I'm concerned, we can just go ahead and accept patches for AF_XDP in libxdp. Does anyone have any thoughts on a preferred workflow? Having the libxdp patches completely separate in a Github PR seems like it will be an annoying workflow, so what to do instead? -Toke
