On Wed, Mar 24, 2021 at 2:07 PM John Fastabend <john.fastabend@xxxxxxxxx> wrote: > > With a relatively recent clang master branch test_map skips a section, > > libbpf: elf: skipping unrecognized data section(5) .rodata.str1.1 > So it was on my TODO list for a while to get rid of this by combining all .rodata* sections into one at load time. I even outline that in "libbpf v1.0" doc ([0]). I just haven't gotten to implementing this yet. You can safely ignore this for now. But I also have nothing against cleaning up tests, of course. [0] https://docs.google.com/document/d/1UyjTZuPFWiPFyKk1tV5an11_iaRuec6U-ZESZ54nNTY > the cause is some pointless strings from bpf_printks in the BPF program > loaded during testing. Remove them so we stop tripping our test bots. > > Signed-off-by: John Fastabend <john.fastabend@xxxxxxxxx> > --- > .../selftests/bpf/progs/sockmap_tcp_msg_prog.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/tools/testing/selftests/bpf/progs/sockmap_tcp_msg_prog.c b/tools/testing/selftests/bpf/progs/sockmap_tcp_msg_prog.c > index fdb4bf4408fa..0f603253f4ed 100644 > --- a/tools/testing/selftests/bpf/progs/sockmap_tcp_msg_prog.c > +++ b/tools/testing/selftests/bpf/progs/sockmap_tcp_msg_prog.c > @@ -16,10 +16,7 @@ int bpf_prog1(struct sk_msg_md *msg) > if (data + 8 > data_end) > return SK_DROP; > > - bpf_printk("data length %i\n", (__u64)msg->data_end - (__u64)msg->data); > d = (char *)data; > - bpf_printk("hello sendmsg hook %i %i\n", d[0], d[1]); > - > return SK_PASS; > } > >
