On Wed, Mar 17, 2021 at 01:03:02PM +0100, Toke Høiland-Jørgensen wrote: > FYI, this no longer applies to bpf-next due to Björn's refactor in > commit: ee75aef23afe ("bpf, xdp: Restructure redirect actions") Thanks Toke, I need to see how to get the map via map_id, does bpf_map_get_curr_or_next() works? Should I call bpf_map_put() after using? The ri->flags = flags also need to be add back as we need to use the flags value. This looks like an opposite of Björn's restructure... And I have expected another rebase after Lorenzo's "bpf: devmap: move drop error path to devmap for XDP_REDIRECT" > > Also, two small nits below: Thanks, I will fix them if there is a way to do the rebase. Hangbin