On 2/19/21 1:23 PM, Lorenz Bauer wrote: > On Fri, 19 Feb 2021 at 11:49, Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote: >> >>> + case SO_NETNS_COOKIE: >>> + lv = sizeof(u64); >>> + if (len < lv) >>> + return -EINVAL; >> >> if (len != lv) >> return -EINVAL; >> >> (There is no reason to support bigger value before at least hundred years) > > Sorry that was copy pasta from SO_COOKIE which uses the same check. I'll > change it to your suggestion. Want me to fix SO_COOKIE as well? Unfortunately it is too late for SO_COOKIE Some applications might use len = 256, and just look at what the kernel gives back. Better be strict at the time a feature is added, instead of having to maintain legacy stuff.
