On Fri, 19 Feb 2021 at 11:49, Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote: > > > + case SO_NETNS_COOKIE: > > + lv = sizeof(u64); > > + if (len < lv) > > + return -EINVAL; > > if (len != lv) > return -EINVAL; > > (There is no reason to support bigger value before at least hundred years) Sorry that was copy pasta from SO_COOKIE which uses the same check. I'll change it to your suggestion. Want me to fix SO_COOKIE as well? > > > +#ifdef CONFIG_NET_NS > > + v.val64 = sock_net(sk)->net_cookie; > > +#else > > + v.val64 = init_net.net_cookie; > > +#endif > > + break; > > + > > Why using this ugly #ifdef ? > > The following should work just fine, even if CONFIG_NET_NS is not set. > > v.val64 = sock_net(sk)->net_cookie; I looked at sock_net and didn't understand how it avoids a compile error so I didn't use it, thanks for pointing this out. -- Lorenz Bauer | Systems Engineer 6th Floor, County Hall/The Riverside Building, SE1 7PB, UK www.cloudflare.com
