On Wed, Feb 10, 2021 at 12:11 AM Alexei Starovoitov <ast@xxxxxx> wrote:
>
> On 2/9/21 2:47 PM, KP Singh wrote:
> > On Tue, Feb 9, 2021 at 10:01 PM Alexei Starovoitov
> > <alexei.starovoitov@xxxxxxxxx> wrote:
> >>
> >> From: Alexei Starovoitov <ast@xxxxxxxxxx>
> >>
> >> In older non-RT kernels migrate_disable() was the same as preempt_disable().
> >> Since commit 74d862b682f5 ("sched: Make migrate_disable/enable() independent of RT")
> >
> > nit: It would be nice to split out the bit that adds
> > migrate_disbale/enable into a separate patch
> > just to make it more explicit.
>
> Not following. What is the point of splitting it?
> Just adding it without using it for anything?
> That's a bit weird.
> How would it help anything?
The reason why I mentioned this is because you refer to this in the other patch:
https://lore.kernel.org/bpf/20210206170344.78399-1-alexei.starovoitov@xxxxxxxxx/T/#m24cdc785b71adc04ac665fe018956c4f25ca06ae
"Since sleepable programs are now executing under migrate_disable
the per-cpu maps are safe to use.
The map-in-map were ok to use in sleepable from the time sleepable
progs were introduced."
It's just a tiny bit easier to find the commit that added it. But not
a big deal if you think it's not useful to split.
[...]
