On 2/9/21 2:47 PM, KP Singh wrote:
On Tue, Feb 9, 2021 at 10:01 PM Alexei Starovoitov
<alexei.starovoitov@xxxxxxxxx> wrote:
From: Alexei Starovoitov <ast@xxxxxxxxxx>
In older non-RT kernels migrate_disable() was the same as preempt_disable().
Since commit 74d862b682f5 ("sched: Make migrate_disable/enable() independent of RT")
nit: It would be nice to split out the bit that adds
migrate_disbale/enable into a separate patch
just to make it more explicit.
Not following. What is the point of splitting it?
Just adding it without using it for anything?
That's a bit weird.
How would it help anything?
migrate_disable() is real and doesn't prevent sleeping.
Use it to efficiently compute execution stats for sleepable bpf programs.
migrate_disable() will also be used to enable per-cpu maps in sleepable programs
in the future patches.
Signed-off-by: Alexei Starovoitov <ast@xxxxxxxxxx>
Acked-by: Andrii Nakryiko <andrii@xxxxxxxxxx>
Just the optional comment about splitting the migrate_enable / disable bit.
Acked-by: KP Singh <kpsingh@xxxxxxxxxx>