Cong Wang wrote: > On Mon, Feb 8, 2021 at 12:21 AM John Fastabend <john.fastabend@xxxxxxxxx> wrote: > > > > Cong Wang wrote: > > > From: Cong Wang <cong.wang@xxxxxxxxxxxxx> > > > > > > Before we add non-TCP support, it is necessary to rename > > > BPF_STREAM_PARSER as it will be no longer specific to TCP, > > > and it does not have to be a parser either. > > > > > > This patch renames BPF_STREAM_PARSER to BPF_SOCK_MAP, so > > > that sock_map.c hopefully would be protocol-independent. > > > > > > Also, improve its Kconfig description to avoid confusion. > > > > > > Cc: John Fastabend <john.fastabend@xxxxxxxxx> > > > Cc: Daniel Borkmann <daniel@xxxxxxxxxxxxx> > > > Cc: Jakub Sitnicki <jakub@xxxxxxxxxxxxxx> > > > Cc: Lorenz Bauer <lmb@xxxxxxxxxxxxxx> > > > Signed-off-by: Cong Wang <cong.wang@xxxxxxxxxxxxx> > > > --- > > > > The BPF_STREAM_PARSER config was originally added because we need > > the STREAM_PARSER define and wanted a way to get the 'depends on' > > lines in Kconfig correct. > > > > Rather than rename this, lets reduce its scope to just the set > > of actions that need the STREAM_PARSER, this should be just the > > stream parser programs. We probably should have done this sooner, > > but doing it now will be fine. > > This makes sense, but we still need a Kconfig for the rest sockmap > code, right? At least for the dependency on NET_SOCK_MSG? Lets just enable NET_SOCK_MSG when CONFIG_BPF_SYSCALL is enabled. We never put any of the other maps, devmap, cpumap, etc. behind an explicit flag like this. > > > > > I can probably draft a quick patch tomorrow if above is not clear. > > It can go into bpf-next outside this series as well to reduce > > the 19 patches a bit. > > I can handle it in my next update too, like all other feedbacks. Great thanks. Especially because I haven't got to it yet today. > > Thanks.
