On Tue, 20 Oct 2020 12:14:16 -0600 David Ahern wrote:
> On 10/20/20 12:03 PM, Toke Høiland-Jørgensen wrote:
> > Jakub Kicinski <kuba@xxxxxxxxxx> writes:
> >> On Tue, 20 Oct 2020 12:51:02 +0200 Toke Høiland-Jørgensen wrote:
> >>> +struct bpf_nh_params {
> >>> + u8 nh_family;
> >>> + union {
> >>> + __u32 ipv4_nh;
> >>> + struct in6_addr ipv6_nh;
> >>> + };
> >>> +};
> >>
> >> Folks, not directly related to this set, but there's a SRv6 patch going
> >> around which adds ifindex, otherwise nh can't be link local.
> >>
> >> I wonder if we want to consider this use case from the start (or the
> >> close approximation of start in this case ;)).
> >
> > The ifindex is there, it's just in the function call signature instead
> > of the struct... Or did you mean something different?
>
> ifindex as the first argument qualifies the device for the address.
Ah, I should have read closer. Seeing there is a plen I assumed all
args would naturally be in the structure, but I'm guessing the case
where params are NULL will be quite common. Don't mind me.
