Re: [PATCH bpf-next v2] bpf: {cpu,dev}map: change various functions return type from int to void

Jesper Dangaard Brouer <brouer@xxxxxxxxxx> · Tue, 1 Sep 2020 11:16:08 +0200

On Tue,  1 Sep 2020 10:39:28 +0200
Björn Töpel <bjorn.topel@xxxxxxxxx> wrote:

> From: Björn Töpel <bjorn.topel@xxxxxxxxx>
> 
> The functions bq_enqueue(), bq_flush_to_queue(), and bq_xmit_all() in
> {cpu,dev}map.c always return zero. Changing the return type from int
> to void makes the code easier to follow.
> 
> Suggested-by: David Ahern <dsahern@xxxxxxxxx>
> Signed-off-by: Björn Töpel <bjorn.topel@xxxxxxxxx>
> ---
>  kernel/bpf/cpumap.c | 11 +++--------
>  kernel/bpf/devmap.c | 15 +++++++--------
>  2 files changed, 10 insertions(+), 16 deletions(-)

Thanks for the cleanup! :-)

Acked-by: Jesper Dangaard Brouer <brouer@xxxxxxxxxx>

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer