On Wed, Jun 24, 2020 at 11:19 AM Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx> wrote: > > On Tue, Jun 23, 2020 at 11:51 PM Andrii Nakryiko > <andrii.nakryiko@xxxxxxxxx> wrote: > > > > long > > represent reality, it causes more straightforward code generation, if > > you don't aritifically down-cast types. > > yep. s/int/long/ conversion in bpf_helpers_def.h definitely improves > generated code. > > > But even better is to just fix types of your local variables to match > > native BPF size. > > I've applied int to long conversion for test_get_stack_rawtp.c test for now. > > Let's try to keep 100% passing rate for test_progs and test_progs-no_alu32 :) Yeah, my bad. I was 100% sure that I tested both back when I did the change, but nothing is 100% in this world, apparently :) As for test_progs-no_alu32, I'll add them to Travis CI as well (right now we only run test_progs), that will help. But I'll try to keep test_progs-no_alu32 in mind when doing tests locally as well.
