Re: [PATCH v3 bpf-next 2/3] selftests/bpf: add variable-length data concatenation pattern test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 23, 2020 at 11:51 PM Andrii Nakryiko
<andrii.nakryiko@xxxxxxxxx> wrote:
>
> long
> represent reality, it causes more straightforward code generation, if
> you don't aritifically down-cast types.

yep. s/int/long/ conversion in bpf_helpers_def.h definitely improves
generated code.

> But even better is to just fix types of your local variables to match
> native BPF size.

I've applied int to long conversion for test_get_stack_rawtp.c test for now.

Let's try to keep 100% passing rate for test_progs and test_progs-no_alu32 :)



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux