Hi, Daniel! >>>>> On Tue, 26 May 2020 23:48:01 +0200, Daniel Borkmann wrote: > On 5/22/20 8:40 AM, Yauheni Kaliuta wrote: >> >> Actually, a bit more needed :) > Not quite sure how to parse this, I presume you are intending > to send a v2 of this series with [0] folded in? Please also do > not add line-breaks in the middle of all your Fixes tags as > otherwise it would break searching for commits in the git > log. For the v2 respin, please also add a better cover letter > than just saying nothing more than 'I had a look, here are > some fixes.'. At least a minimal high level summary of the > selftest Makefile changes in this series. Thanks! That was part of thread with Andrii, but I should have sent separated. Anyway (see Andrii's comments) it's not coming as is, so I'll do v2. Sorry for that. > Thanks, > Daniel > [0] > https://patchwork.ozlabs.org/project/netdev/patch/20200522081901.238516-1-yauheni.kaliuta@xxxxxxxxxx/ >>>>>>> On Fri, 22 May 2020 07:13:02 +0300, Yauheni Kaliuta wrote: >> >> > I had a look, here are some fixes. >> > Yauheni Kaliuta (8): >> > selftests/bpf: remove test_align from Makefile >> > selftests/bpf: build bench.o for any $(OUTPUT) >> > selftests/bpf: install btf .c files >> > selftests/bpf: fix object files installation >> > selftests/bpf: add output dir to include list >> > selftests/bpf: fix urandom_read installation >> > selftests/bpf: fix test.h placing for out of tree build >> > selftests/bpf: factor out MKDIR rule >> >> > tools/testing/selftests/bpf/Makefile | 77 ++++++++++++++++++++-------- >> > 1 file changed, 55 insertions(+), 22 deletions(-) >> >> > -- >> > 2.26.2 >> >> -- WBR, Yauheni Kaliuta