Re: [PATCH 0/8] selftests/bpf: installation and out of tree build fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 21, 2020 at 11:41 PM Yauheni Kaliuta
<yauheni.kaliuta@xxxxxxxxxx> wrote:
>
>
> Actually, a bit more needed :)

>From the other kselftest thread, it seems like selftests are not
supporting builds out-of-tree. With that, wouldn't it be simpler to
build in tree and then just copy selftests/bpf directory to wherever
you need to run tests from? It would be simple and reliable. Given I
and probably everyone else never build and run tests out-of-tree, it's
just too easy to break this and you'll be constantly chasing some
non-obvious breakages...

Is there some problem with such approach?

>
> >>>>> On Fri, 22 May 2020 07:13:02 +0300, Yauheni Kaliuta  wrote:
>
>  > I had a look, here are some fixes.
>  > Yauheni Kaliuta (8):
>  >   selftests/bpf: remove test_align from Makefile
>  >   selftests/bpf: build bench.o for any $(OUTPUT)
>  >   selftests/bpf: install btf .c files
>  >   selftests/bpf: fix object files installation
>  >   selftests/bpf: add output dir to include list
>  >   selftests/bpf: fix urandom_read installation
>  >   selftests/bpf: fix test.h placing for out of tree build
>  >   selftests/bpf: factor out MKDIR rule
>
>  >  tools/testing/selftests/bpf/Makefile | 77 ++++++++++++++++++++--------
>  >  1 file changed, 55 insertions(+), 22 deletions(-)
>
>  > --
>  > 2.26.2
>
>
> --
> WBR,
> Yauheni Kaliuta
>



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux