On Tue, May 19, 2020 at 11:16 PM Yauheni Kaliuta <yauheni.kaliuta@xxxxxxxxxx> wrote: > > Hi, Andrii! > > >>>>> On Tue, 19 May 2020 12:09:36 -0700, Andrii Nakryiko wrote: > > > On Tue, May 19, 2020 at 1:50 AM Yauheni Kaliuta > > <yauheni.kaliuta@xxxxxxxxxx> wrote: > >> > >> Some .c files used by test_progs to check btf and they are missing > >> from installation after commit 74b5a5968fe8 ("selftests/bpf: Replace > >> test_progs and test_maps w/ general rule"). > >> > >> Take them back. > >> > >> Fixes: 74b5a5968fe8 ("selftests/bpf: Replace test_progs and > >> test_maps w/ general rule") > >> > >> Signed-off-by: Yauheni Kaliuta <yauheni.kaliuta@xxxxxxxxxx> > >> --- > >> tools/testing/selftests/bpf/Makefile | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile > >> index e716e931d0c9..d96440732905 100644 > >> --- a/tools/testing/selftests/bpf/Makefile > >> +++ b/tools/testing/selftests/bpf/Makefile > >> @@ -46,6 +46,9 @@ TEST_GEN_FILES = > >> TEST_FILES = test_lwt_ip_encap.o \ > >> test_tc_edt.o > >> > >> +BTF_C_FILES = $(wildcard progs/btf_dump_test_case_*.c) > >> +TEST_FILES += $(BTF_C_FILES) > > > Can you please re-use BTF_C_FILES in TRUNNER_EXTRA_FILES := > > assignment on line 357? > > Do you mean this: Yes, you can add my Acked-by: Andrii Nakryiko <andriin@xxxxxx>. Test_progs flavors can be addressed separately, I think. [...]