Em Wed, May 20, 2020 at 11:22:22AM -0700, Ian Rogers escreveu: > On Wed, May 20, 2020 at 6:14 AM Jiri Olsa <jolsa@xxxxxxxxxx> wrote: > > > break; > > > } > > > } > > > + if (!ret) { > > > > could you please do instead: > > > > if (ret) > > return ret; > > > > so the code below cuts down one indent level and you > > don't need to split up the lines > > Done, broken out as a separate patch in v2: > https://lore.kernel.org/lkml/20200520182011.32236-3-irogers@xxxxxxxxxx/ Jiri, was this the only issue with this patchkit? I've merged already the first one, that you acked. - Arnaldo