Hi, Andrii! >>>>> On Tue, 12 May 2020 15:13:18 -0700, Andrii Nakryiko wrote: > On Tue, May 12, 2020 at 1:16 PM Yauheni Kaliuta > <yauheni.kaliuta@xxxxxxxxxx> wrote: >> >> Hi, Andrii! >> >> The patch blanks TEST_GEN_FILES which was used by install target >> (lib.mk) to install test progs. How is it supposed to work? >> > I actually never used install for selftests, just make and > then run individual test binaries, which explains why this > doesn't work :) Ok :) Thanks for the clarification. >> That fixes it for me btw: >> >> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile >> index 8f25966b500b..1f878dcd2bf6 100644 >> --- a/tools/testing/selftests/bpf/Makefile >> +++ b/tools/testing/selftests/bpf/Makefile >> @@ -265,6 +265,7 @@ TRUNNER_BPF_OBJS := $$(patsubst %.c,$$(TRUNNER_OUTPUT)/%.o, $$(TRUNNER_BPF_SRCS) >> TRUNNER_BPF_SKELS := $$(patsubst %.c,$$(TRUNNER_OUTPUT)/%.skel.h, \ >> $$(filter-out $(SKEL_BLACKLIST), \ >> $$(TRUNNER_BPF_SRCS))) >> +TEST_GEN_FILES += $$(TRUNNER_BPF_OBJS) > Yeah, this makes sense, these files will be copied over along > the compiled test_xxx binaries. Do you mind submitting a > patch? No, sure, I'll do. -- WBR, Yauheni Kaliuta
