On Tue, Apr 28, 2020 at 5:15 PM Andrii Nakryiko
<andrii.nakryiko@xxxxxxxxx> wrote:
>
> On Tue, Apr 28, 2020 at 12:40 PM Daniel Borkmann <daniel@xxxxxxxxxxxxx> wrote:
> >
> > On 4/28/20 8:57 PM, Andrii Nakryiko wrote:
> > > On Tue, Apr 28, 2020 at 10:38 AM Veronika Kabatova <vkabatov@xxxxxxxxxx> wrote:
> > >>
> > >> $(OUTPUT)/runqslower makefile target doesn't actually create runqslower
> > >> binary in the $(OUTPUT) directory. As lib.mk expects all
> > >> TEST_GEN_PROGS_EXTENDED (which runqslower is a part of) to be present in
> > >> the OUTPUT directory, this results in an error when running e.g. `make
> > >> install`:
> > >>
> > >> rsync: link_stat "tools/testing/selftests/bpf/runqslower" failed: No
> > >> such file or directory (2)
> > >>
> > >> Copy the binary into the OUTPUT directory after building it to fix the
> > >> error.
> > >>
> > >> Fixes: 3a0d3092a4ed ("selftests/bpf: Build runqslower from selftests")
> > >> Signed-off-by: Veronika Kabatova <vkabatov@xxxxxxxxxx>
> > >> ---
> > >
> > > Acked-by: Andrii Nakryiko <andriin@xxxxxx>
> >
> > Applied, thanks!
>
> Veronika,
>
> This change leaves runqslower laying around in selftests/bpf directory
> and available to be committed into git. Can you please follow up with
> adding runqslower to .gitignore? Thanks!
Never mind anymore, sent fix as part of ASAN fixes patch set.
