On Thu, Apr 2, 2020 at 8:46 AM Joe Stringer <joe@xxxxxxxxxxx> wrote: > > I'll take a look. Should just be iproute2 package I believe. > For anyone following along. iproute2, which is now a dependency of sk_assign selftest brings in a ton of dependencies, including systemd itself. This, beyond causing linux image problems we haven't investigated too deeply, also increases our image almost three-fold. See [0] for github discussion on topic. So for now I'm going to disable sk_assign selftest permanently in libbpf tests. Ideally sk_assign can be written to not rely on iproute2 to set things up. But until then, it won't be exercised in libbpf's CI tests, unfortunately. [0] https://github.com/libbpf/libbpf/pull/144#issuecomment-608170330 > On Wed, Apr 1, 2020, 16:20 Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx> wrote: >> >> On Sun, Mar 29, 2020 at 3:58 PM Joe Stringer <joe@xxxxxxxxxxx> wrote: >> > >> > From: Lorenz Bauer <lmb@xxxxxxxxxxxxxx> >> > >> > Attach a tc direct-action classifier to lo in a fresh network >> > namespace, and rewrite all connection attempts to localhost:4321 >> > to localhost:1234 (for port tests) and connections to unreachable >> > IPv4/IPv6 IPs to the local socket (for address tests). Includes >> > implementations for both TCP and UDP. >> > >> > Keep in mind that both client to server and server to client traffic >> > passes the classifier. >> > >> > Signed-off-by: Lorenz Bauer <lmb@xxxxxxxxxxxxxx> >> > Co-authored-by: Joe Stringer <joe@xxxxxxxxxxx> >> > Signed-off-by: Joe Stringer <joe@xxxxxxxxxxx> >> > Acked-by: Martin KaFai Lau <kafai@xxxxxx> >> > --- >> > v5: No change >> > v4: Add acks >> > v3: Add tests for UDP socket assign >> > Fix switching back to original netns after test >> > Avoid using signals to timeout connections >> > Refactor to iterate through test cases >> > v2: Rebase onto test_progs infrastructure >> > v1: Initial commit >> > --- >> >> Hey Joe! >> >> When syncing libbpf to Github, this selftest is now failing with the >> follow errors: >> >> tc: command line is not complete, try "help" >> configure_stack:FAIL:46 >> configure_stack: Interrupted system call >> #49 sk_assign:FAIL >> >> We are probably missing some packages or something like that. Could >> you please help figuring out how we need to adjust libbpf Travis CI >> environment to accomodate this? Thanks! >> You can find one of the failed runs at [0] >> >> [0] https://travis-ci.com/github/anakryiko/libbpf/jobs/311759005