On 1/29/20 8:28 PM, Alexei Starovoitov wrote:
On Wed, Jan 29, 2020 at 8:25 AM Daniel Borkmann <daniel@xxxxxxxxxxxxx> wrote:
Fixes: 849fa50662fbc ("bpf/verifier: refine retval R0 state for bpf_get_stack helper")
Signed-off-by: John Fastabend <john.fastabend@xxxxxxxxx>
Applied, thanks!
Daniel,
did you run the selftests before applying?
This patch breaks two.
We have to find a different fix.
./test_progs -t get_stack
68: (85) call bpf_get_stack#67
R0=inv(id=0,smax_value=800) R1_w=ctx(id=0,off=0,imm=0)
R2_w=map_value(id=0,off=0,ks=4,vs=1600,umax_value=4294967295,var_off=(0x0;
0xffffffff)) R3_w=inv(id=0,umax_value=4294967295,var_off=(0x0;
0xffffffff)) R4_w=inv0 R6=ctx(id=0,off=0,im?
R2 unbounded memory access, make sure to bounds check any array access
into a map
Sigh, had it in my wip pre-rebase tree when running tests. I've revert it from the
tree since this needs to be addressed. Sorry for the trouble.
Thanks,
Daniel