On Fri, 2025-02-28 at 17:52 +0000, Mykyta Yatsenko wrote:
[...]
> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
> index 9ced1ce2334c..dd2f64903c3b 100644
> --- a/tools/lib/bpf/libbpf.c
> +++ b/tools/lib/bpf/libbpf.c
> @@ -4858,7 +4858,7 @@ bool bpf_map__autocreate(const struct bpf_map *map)
>
> int bpf_map__set_autocreate(struct bpf_map *map, bool autocreate)
> {
> - if (map->obj->state >= OBJ_LOADED)
> + if (map->obj->state >= OBJ_PREPARED)
> return libbpf_err(-EBUSY);
I looked through logic in patches #1 and #2 and changes look correct.
Running tests under valgrind does not show issues with this feature.
The only ask from my side is to consider doing ==/!= comparisons in
cases like above. E.g. it seems that `map->obj->state != OBJ_OPENED`
is a bit simpler to understand when reading condition above.
Or maybe that's just me.
> map->autocreate = autocreate;
[...]
