RE: [PATCH bpf-next v2 01/11] bpf, sk_msg: Don't reset saved sock proto on restore

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jakub Sitnicki wrote:
> There is no need to reset psock->sk_proto when restoring socket protocol
> callbacks (sk->sk_prot). The psock is about to get detached from the sock
> and eventually destroyed.
> 
> No harm done if we restore the protocol callbacks twice, while it makes
> reasoning about psock state easier, that is once psock was initialized, we
> can assume psock->sk_proto is set.
> 
> Also, we don't need a fallback for when socket is not using ULP.
> tcp_update_ulp already does this for us.
> 
> Signed-off-by: Jakub Sitnicki <jakub@xxxxxxxxxxxxxx>
> ---

Acked-by: John Fastabend <john.fastabend@xxxxxxxxx>



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux