Re: [PATCH bpf-next v1 7/7] selftests/bpf: Add IRQ save/restore tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2024-11-21 at 23:07 +0100, Kumar Kartikeya Dwivedi wrote:

[...]

> > > +SEC("?tc")
> > > +__success
> > > +int irq_balance_n_subprog(struct __sk_buff *ctx)
> > 
> > Nit: don't think this test adds much given irq_balance_n()
> >      and irq_balance_subprog().
> 
> My idea with both of these was to ensure when the state is copied in
> and out on calls and when we're doing one or more than one
> save/restore (which links prev_id into active_irq_id etc.) we don't
> have problems, so they were definitely testing different scenarios.
> But with the move into bpf_verifier_state they will indeed become
> redundant, so I'm going to drop them in v2.

Understood, thank you for explaining.






[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux