2024-11-12 12:02 UTC+0100 ~ Daan De Meyer <daan.j.demeyer@xxxxxxxxx> >> My understanding of the check on building_out_of_srctree in >> tools/bpf/Makefile (from commit 55d554f5d140's description) is that it >> fixes the build from "make TARGETS=bpf kselftest", not from "make -C >> tools/bpf". > >> Trying again "make ARCH=x86 -C tools/bpf/bpftool bootstrap" at the root >> of the Linux repo, not building out-of-tree, this works fine for me, >> without the need for your patch. I'm trying to understand what you >> setup is and what creates the failure that you observe (and that I can't >> reproduce), so I'd like more context if possible. Are you just running >> that command from the root of the tree? If that's the case, what values >> do you observe for $(srctree) and $(building_out_of_srctree) when >> entering bpftool's Makefile? > > I do the same thing and I get this error, srctree is set to ".". I have no clue > what's different about my environment that would cause this error. This is > a Fedora Rawhide image and I'm using the master branch from Linus's repo > (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git) Hi Daan, I'm sorry I still don't manage to reproduce. I installed a VM with a Rawhide image (Fedora-Workstation-Live-x86_64-Rawhide-20241112.n.0.iso), I installed packages elfutils-libelf-devel, gcc, and make in it, I cloned Linus' repo, and ran the same command as you did (make ARCH=x86 -C tools/bpf/bpftool bootstrap), and this works well for me. test@localhost-live:~/linux$ lsb_release -a LSB Version: n/a Distributor ID: Fedora Description: Fedora Linux 42 (Workstation Edition Prerelease) Release: 42 Codename: n/a test@localhost-live:~/linux$ uname -r 6.12.0-0.rc7.58.fc42.x86_64 $(srctree) appears to be empty in my case. Have you tried tracing it (and $(building_out_of_srctree)) with -p to see where it's set in your case? Quentin
