On Mon, Oct 21, 2024 at 6:52 PM Paolo Abeni <pabeni@xxxxxxxxxx> wrote:
>
> On 10/15/24 16:07, Menglong Dong wrote:
> > @@ -2316,19 +2327,25 @@ static int ip_route_input_slow(struct sk_buff *skb, __be32 daddr, __be32 saddr,
> > err = -EHOSTUNREACH;
> > goto no_route;
> > }
> > - if (res->type != RTN_UNICAST)
> > + if (res->type != RTN_UNICAST) {
> > + reason = SKB_DROP_REASON_IP_INVALID_DEST;
> > goto martian_destination;
> > + }
> >
> > make_route:
> > err = ip_mkroute_input(skb, res, in_dev, daddr, saddr, dscp, flkeys);
> > -out: return err;
> > + if (!err)
> > + reason = SKB_NOT_DROPPED_YET;
> > +
> > +out: return reason;
>
> Since you are touching this line, please rewrite the code with a more
> natural indentation:
>
> out:
> return reason;
>
Okay!
> Thanks,
>
> Paolo
>
