On Mon, Oct 21, 2024 at 6:49 PM Paolo Abeni <pabeni@xxxxxxxxxx> wrote: > > > > On 10/21/24 12:44, Paolo Abeni wrote: > > On 10/15/24 16:07, Menglong Dong wrote: > >> diff --git a/net/core/lwt_bpf.c b/net/core/lwt_bpf.c > >> index e0ca24a58810..a4652f2a103a 100644 > >> --- a/net/core/lwt_bpf.c > >> +++ b/net/core/lwt_bpf.c > >> @@ -98,6 +98,7 @@ static int bpf_lwt_input_reroute(struct sk_buff *skb) > >> skb_dst_drop(skb); > >> err = ip_route_input_noref(skb, iph->daddr, iph->saddr, > >> ip4h_dscp(iph), dev); > >> + err = err ? -EINVAL : 0; > > > > Please introduce and use a drop_reason variable here instead of 'err', > > to make it clear the type conversion. > > Or even better, collapse the 2 statements: > > err = ip_route_input_noref(skb, iph->daddr, iph->saddr, > ip4h_dscp(iph), dev) ? -EINVAL : 0; > > There are other places which could use a similar changes. > Yeah, it makes things much more clear. Thanks! Menglong Dong > Thanks, > > Paolo >
