On Fri, 20 Dec 2019 at 11:30, Toke Høiland-Jørgensen <toke@xxxxxxxxxx> wrote: > > Jesper Dangaard Brouer <brouer@xxxxxxxxxx> writes: > [...] > > I have now went over the entire patchset, and everything look perfect, > > I will go as far as saying it is brilliant. We previously had the > > issue, that using different redirect maps in a BPF-prog would cause the > > bulking effect to be reduced, as map_to_flush cause previous map to get > > flushed. This is now solved :-) > > Another thing that occurred to me while thinking about this: Now that we > have a single flush list, is there any reason we couldn't move the > devmap xdp_bulk_queue into struct net_device? That way it could also be > used for the non-map variant of bpf_redirect()? > Indeed! (At least I don't see any blockers...)
