Jesper Dangaard Brouer <brouer@xxxxxxxxxx> writes: > On Fri, 20 Dec 2019 08:46:51 +0100 > Jesper Dangaard Brouer <brouer@xxxxxxxxxx> wrote: > >> On Thu, 19 Dec 2019 21:21:39 -0800 >> Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx> wrote: >> >> > > v1->v2 [1]: >> > > * Removed 'unused-variable' compiler warning (Jakub) >> > > >> > > [1] https://lore.kernel.org/bpf/20191218105400.2895-1-bjorn.topel@xxxxxxxxx/ >> > >> > My understanding that outstanding discussions are not objecting to the >> > core ideas of the patch set, hence applied. Thanks >> >> I had hoped to have time to review it in details today. But as I don't >> have any objecting to the core ideas, then I don't mind it getting >> applied. We can just fix things in followups. > > I have now went over the entire patchset, and everything look perfect, > I will go as far as saying it is brilliant. We previously had the > issue, that using different redirect maps in a BPF-prog would cause the > bulking effect to be reduced, as map_to_flush cause previous map to get > flushed. This is now solved :-) Another thing that occurred to me while thinking about this: Now that we have a single flush list, is there any reason we couldn't move the devmap xdp_bulk_queue into struct net_device? That way it could also be used for the non-map variant of bpf_redirect()? -Toke
