On 10/11/24 10:40, Stefano Garzarella wrote: > On Thu, Oct 10, 2024 at 05:09:17PM GMT, Robert Eshleman . wrote: >> On Thu, Oct 10, 2024 at 1:49 AM Stefano Garzarella <sgarzare@xxxxxxxxxx> >> wrote: >>> >>> The modification looks good to me, but now that I'm looking at it >>> better, I don't understand why we don't also call >>> virtio_transport_send_credit_update(). >>> >>> This is to inform the peer that we've freed up space and it has more >>> credit. >>> >>> @Bobby do you remember? >>> >>> >> I do not remember, but I do think it seems wrong not to. > > Yeah, @Michal can you also add that call? > > For now just call it, without the optimization we did for stream > packets, in the future I'll try to unify the paths. Sure, here is v2: https://lore.kernel.org/bpf/20241013-vsock-fixes-for-redir-v2-0-d6577bbfe742@xxxxxxx Thanks, Michal
