Re: [External] Re: [PATCH bpf 2/4] vsock: Update rx_bytes on read_skb()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 10, 2024 at 05:09:17PM GMT, Robert Eshleman . wrote:
On Thu, Oct 10, 2024 at 1:49 AM Stefano Garzarella <sgarzare@xxxxxxxxxx>
wrote:


The modification looks good to me, but now that I'm looking at it
better, I don't understand why we don't also call
virtio_transport_send_credit_update().

This is to inform the peer that we've freed up space and it has more
credit.

@Bobby do you remember?


I do not remember, but I do think it seems wrong not to.

Yeah, @Michal can you also add that call?

For now just call it, without the optimization we did for stream packets, in the future I'll try to unify the paths.

Thanks,
Stefano



I think we should try to unify the receiving path used through BPF or
not (not for this series of course).

Thanks,
Stefano






[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux