no longer applies, please respin
On Tue, 1 Oct 2024 13:59:59 +0800 Menglong Dong wrote:
> + enum skb_drop_reason drop_reason = SKB_DROP_REASON_NOT_SPECIFIED;
> const struct iphdr *iph = ip_hdr(skb);
> - int err, drop_reason;
> + int err;
> struct rtable *rt;
reverse xmas tree
>
> - drop_reason = SKB_DROP_REASON_NOT_SPECIFIED;
> -
> if (ip_can_use_hint(skb, iph, hint)) {
> err = ip_route_use_hint(skb, iph->daddr, iph->saddr, iph->tos,
> dev, hint);
> @@ -363,7 +362,7 @@ static int ip_rcv_finish_core(struct net *net, struct sock *sk,
> */
> if (!skb_valid_dst(skb)) {
> err = ip_route_input_noref(skb, iph->daddr, iph->saddr,
> - iph->tos, dev);
> + iph->tos, dev, &drop_reason);
I find the extra output argument quite ugly.
I can't apply this now to try to suggest something better, perhaps you
can come up with a better solution..
--
pw-bot: cr
