Em Fri, Dec 20, 2019 at 02:00:48PM -0800, Andrii Nakryiko escreveu: > On Fri, Dec 20, 2019 at 1:53 PM Arnaldo Carvalho de Melo <arnaldo.melo@xxxxxxxxx> wrote: > > Em Fri, Dec 20, 2019 at 01:45:52PM -0800, Andrii Nakryiko escreveu: > > > On Fri, Dec 20, 2019 at 12:47 PM Arnaldo Carvalho de Melo <arnaldo.melo@xxxxxxxxx> wrote: > > > > Shouldn't this be applied to the current merge window since a behaviour > > > > that people relied, i.e. using O= to generate the build in a separate > > > > directory, since its not possible to use the source dir tree as it is > > > > read-only is now broken, i.e. isn't this a regression? > > > Sure, it can be applied against bpf as well, but selftests still need > > > to be fixed first. > > I guess this can be done on a separate patch? I.e. if the user doesn't > > use selftests the only regression it will see is when trying to build > > tools/perf using O=. > > I think two patches is best, better granularity, do you see a strict > > need for both to be in the same patch? > Sure, it can be two separate patches, but they should go in together, > otherwise selftests will be broken. Sure, both have to be fixed :-) - Arnaldo