On Fri, 6 Sep 2024 16:22:12 -0700 Alexei Starovoitov wrote:
> > On Fri, 6 Sep 2024 15:41:47 -0700 Alexei Starovoitov wrote:
> > > The urgency is now because the situation is dire.
> > > The verifier assumes that skb is not null and will remove
> > > if (!skb) check assuming that it's a dead code.
> >
> > Meaning verifier currently isn't ready for patch 4?
> > Or we can crash 6.11-rc6 by attaching to a trace_tcp_send_reset()
> > and doing
> > printf("%d\n", skb->len);
> > ?
>
> depends on the prog type and how it's attached, but yes :(
I see :( Thought this is just needed for patch 4.
In this case no objections "from networking perspective":
Acked-by: Jakub Kicinski <kuba@xxxxxxxxxx>
although it feels more like a general tracing question.
