On Thu, 5 Sep 2024 17:26:42 -0700 Alexei Starovoitov wrote: > Yes, it's a bit of a whack a mole and eventually we can get rid of it > with a smarter verifier (likely) or smarter objtool (unlikely). > Long term we should be able to analyze body of TP_fast_assign > automatically and conclude whether it's handling NULL for pointer > arguments or not. bpf verifier can easily do it for bpf code. > We just need to compile TP_fast_assign() as a tiny bpf snippet. > This is work in progress. Can we not wait for that work to conclude, then? AFAIU this whole patch set is just a minor quality of life improvement for BPF progs at the expense of carrying questionable changes upstream. I don't see the urgency.