Re: [PATCH bpf-next] bpf, x64: Fix a jit convergence issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 8/29/24 9:37 AM, Alexei Starovoitov wrote:
On Wed, Aug 28, 2024 at 6:55 PM Yonghong Song <yonghong.song@xxxxxxxxx> wrote:


So we need to apply the same checking is_imm8_cond_offset() to jmp insn.
This should cover all cases.
Looks like it.
If I'm reading it correctly is_imm8_cond_offset() doesn't need
to be 127-4 for jmp. It can be 127-3, since jmp insn can grow by 3 bytes.

Right, 127-3 should work for jmp insn.

But to avoid thinking twice I'd use the same is_imm8_cond_offset()
for both jmp_cond and jmp.

Sounds good. I will add this into commit message as well.





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux