On Wed, Aug 28, 2024 at 6:55 PM Yonghong Song <yonghong.song@xxxxxxxxx> wrote: > > > > So we need to apply the same checking is_imm8_cond_offset() to jmp insn. > This should cover all cases. Looks like it. If I'm reading it correctly is_imm8_cond_offset() doesn't need to be 127-4 for jmp. It can be 127-3, since jmp insn can grow by 3 bytes. But to avoid thinking twice I'd use the same is_imm8_cond_offset() for both jmp_cond and jmp.
