On Mon, Aug 12, 2024 at 12:51:21PM -0400, Jeff Layton wrote: > On Mon, 2024-08-12 at 18:42 +0200, David Sterba wrote: > > On Mon, Aug 12, 2024 at 12:30:52PM -0400, Jeff Layton wrote: > > > Unlink changes the link count on the target inode. POSIX mandates that > > > the ctime must also change when this occurs. > > > > Right, thanks. According to https://pubs.opengroup.org/onlinepubs/9699919799/functions/unlink.html: > > > > Upon successful completion, unlink() shall mark for update the last data > > modification and last file status change timestamps of the parent > > directory. Also, if the file's link count is not 0, the last file status > > change timestamp of the file shall be marked for update. > > > > Weird way to phrase to that. IMO, we still want to stamp the inode's > ctime even if the link count goes to 0. That's what Linux generally > does, anyway. Oh well.. > > > > > > Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx> > > > > Reviewed-by: David Sterba <dsterba@xxxxxxxx> > > > FWIW, this should probably go in via the btrfs tree. Yes, we'll take it.
