>-----Original Message----- >From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of >Zaremba, Larysa >Sent: Wednesday, July 24, 2024 10:19 PM >To: intel-wired-lan@xxxxxxxxxxxxxxxx >Cc: Drewek, Wojciech <wojciech.drewek@xxxxxxxxx>; Fijalkowski, Maciej ><maciej.fijalkowski@xxxxxxxxx>; Jesper Dangaard Brouer <hawk@xxxxxxxxxx>; >Daniel Borkmann <daniel@xxxxxxxxxxxxx>; Zaremba, Larysa ><larysa.zaremba@xxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; John Fastabend ><john.fastabend@xxxxxxxxx>; Alexei Starovoitov <ast@xxxxxxxxxx>; linux- >kernel@xxxxxxxxxxxxxxx; Eric Dumazet <edumazet@xxxxxxxxxx>; Kubiak, >Michal <michal.kubiak@xxxxxxxxx>; Nguyen, Anthony L ><anthony.l.nguyen@xxxxxxxxx>; Nambiar, Amritha ><amritha.nambiar@xxxxxxxxx>; Keller, Jacob E <jacob.e.keller@xxxxxxxxx>; >Jakub Kicinski <kuba@xxxxxxxxxx>; bpf@xxxxxxxxxxxxxxx; Paolo Abeni ><pabeni@xxxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Karlsson, >Magnus <magnus.karlsson@xxxxxxxxx> >Subject: [Intel-wired-lan] [PATCH iwl-net v2 3/6] ice: check for XDP rings >instead of bpf program when unconfiguring > >If VSI rebuild is pending, .ndo_bpf() can attach/detach the XDP program on VSI >without applying new ring configuration. When unconfiguring the VSI, we can >encounter the state in which there is an XDP program but no XDP rings to >destroy or there will be XDP rings that need to be destroyed, but no XDP >program to indicate their presence. > >When unconfiguring, rely on the presence of XDP rings rather then XDP >program, as they better represent the current state that has to be destroyed. > >Reviewed-by: Wojciech Drewek <wojciech.drewek@xxxxxxxxx> >Signed-off-by: Larysa Zaremba <larysa.zaremba@xxxxxxxxx> >--- > drivers/net/ethernet/intel/ice/ice_lib.c | 4 ++-- >drivers/net/ethernet/intel/ice/ice_main.c | 4 ++-- >drivers/net/ethernet/intel/ice/ice_xsk.c | 6 +++--- > 3 files changed, 7 insertions(+), 7 deletions(-) > Tested-by: Chandan Kumar Rout <chandanx.rout@xxxxxxxxx> (A Contingent Worker at Intel)
