>-----Original Message-----
>From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of
>Zaremba, Larysa
>Sent: Wednesday, July 24, 2024 10:19 PM
>To: intel-wired-lan@xxxxxxxxxxxxxxxx
>Cc: Drewek, Wojciech <wojciech.drewek@xxxxxxxxx>; Fijalkowski, Maciej
><maciej.fijalkowski@xxxxxxxxx>; Jesper Dangaard Brouer <hawk@xxxxxxxxxx>;
>Daniel Borkmann <daniel@xxxxxxxxxxxxx>; Zaremba, Larysa
><larysa.zaremba@xxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; John Fastabend
><john.fastabend@xxxxxxxxx>; Alexei Starovoitov <ast@xxxxxxxxxx>; linux-
>kernel@xxxxxxxxxxxxxxx; Eric Dumazet <edumazet@xxxxxxxxxx>; Kubiak,
>Michal <michal.kubiak@xxxxxxxxx>; Nguyen, Anthony L
><anthony.l.nguyen@xxxxxxxxx>; Nambiar, Amritha
><amritha.nambiar@xxxxxxxxx>; Keller, Jacob E <jacob.e.keller@xxxxxxxxx>;
>Jakub Kicinski <kuba@xxxxxxxxxx>; bpf@xxxxxxxxxxxxxxx; Paolo Abeni
><pabeni@xxxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Karlsson,
>Magnus <magnus.karlsson@xxxxxxxxx>
>Subject: [Intel-wired-lan] [PATCH iwl-net v2 5/6] ice: remove ICE_CFG_BUSY
>locking from AF_XDP code
>
>Locking used in ice_qp_ena() and ice_qp_dis() does pretty much nothing,
>because ICE_CFG_BUSY is a state flag that is supposed to be set in a PF state,
>not VSI one. Therefore it does not protect the queue pair from e.g. reset.
>
>Despite being useless, it still can deadlock the unfortunate functions that have
>fell into the same ICE_CFG_BUSY-VSI trap. This happens if ice_qp_ena returns
>an error.
>
>Remove ICE_CFG_BUSY locking from ice_qp_dis() and ice_qp_ena().
>
>Fixes: 2d4238f55697 ("ice: Add support for AF_XDP")
>Reviewed-by: Wojciech Drewek <wojciech.drewek@xxxxxxxxx>
>Signed-off-by: Larysa Zaremba <larysa.zaremba@xxxxxxxxx>
>---
> drivers/net/ethernet/intel/ice/ice_xsk.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
Tested-by: Chandan Kumar Rout <chandanx.rout@xxxxxxxxx> (A Contingent Worker at Intel)
