On Mon, Jul 22, 2024 at 10:55 PM Tony Ambardar <tony.ambardar@xxxxxxxxx> wrote: > > Hello all, > > This series includes the bulk of libc-related compile fixes accumulated to > support systems using musl, with smaller numbers to follow. These patches > are simple and straightforward, and the series has been tested with the > kernel-patches/bpf CI and locally using mips64el-gcc/musl-libc and QEMU > with an OpenWrt rootfs. > > The patches address a few general categories of libc portability issues: > > - missing, redundant or incorrect include headers > - disabled GNU header extensions (i.e. missing #define _GNU_SOURCE) > - issues with types and casting > > Feedback and suggestions for improvement are welcome! > > Thanks, > Tony > > Tony Ambardar (19): > selftests/bpf: Use pid_t consistently in test_progs.c > selftests/bpf: Fix compile error from rlim_t in sk_storage_map.c > selftests/bpf: Fix error compiling bpf_iter_setsockopt.c with musl > libc > selftests/bpf: Drop unneeded include in unpriv_helpers.c > selftests/bpf: Drop unneeded include in sk_lookup.c > selftests/bpf: Drop unneeded include in flow_dissector.c I squashed the above three patches into one, as they are the same kind of fix with the same reasoning. The rest at least have a specific error example, so I didn't touch them. But generally speaking, I think it's fair to combine the same kind of fixes across a few files (for the future). Applied to bpf-next, thanks. > selftests/bpf: Fix missing ARRAY_SIZE() definition in bench.c > selftests/bpf: Fix missing UINT_MAX definitions in benchmarks > selftests/bpf: Fix missing BUILD_BUG_ON() declaration > selftests/bpf: Fix include of <sys/fcntl.h> > selftests/bpf: Fix compiling parse_tcp_hdr_opt.c with musl-libc > selftests/bpf: Fix compiling kfree_skb.c with musl-libc > selftests/bpf: Fix compiling flow_dissector.c with musl-libc > selftests/bpf: Fix compiling tcp_rtt.c with musl-libc > selftests/bpf: Fix compiling core_reloc.c with musl-libc > selftests/bpf: Fix errors compiling lwt_redirect.c with musl libc > selftests/bpf: Fix errors compiling decap_sanity.c with musl libc > selftests/bpf: Fix errors compiling crypto_sanity.c with musl libc > selftests/bpf: Fix errors compiling cg_storage_multi.h with musl libc > > tools/testing/selftests/bpf/bench.c | 1 + > tools/testing/selftests/bpf/bench.h | 1 + > tools/testing/selftests/bpf/map_tests/sk_storage_map.c | 2 +- > tools/testing/selftests/bpf/prog_tests/bpf_iter_setsockopt.c | 2 +- > tools/testing/selftests/bpf/prog_tests/core_reloc.c | 1 + > tools/testing/selftests/bpf/prog_tests/crypto_sanity.c | 1 - > tools/testing/selftests/bpf/prog_tests/decap_sanity.c | 1 - > tools/testing/selftests/bpf/prog_tests/flow_dissector.c | 2 +- > tools/testing/selftests/bpf/prog_tests/kfree_skb.c | 1 + > tools/testing/selftests/bpf/prog_tests/lwt_redirect.c | 1 - > tools/testing/selftests/bpf/prog_tests/ns_current_pid_tgid.c | 2 +- > tools/testing/selftests/bpf/prog_tests/parse_tcp_hdr_opt.c | 1 + > tools/testing/selftests/bpf/prog_tests/sk_lookup.c | 1 - > tools/testing/selftests/bpf/prog_tests/tcp_rtt.c | 1 + > tools/testing/selftests/bpf/prog_tests/user_ringbuf.c | 1 + > tools/testing/selftests/bpf/progs/cg_storage_multi.h | 2 -- > tools/testing/selftests/bpf/test_progs.c | 2 +- > tools/testing/selftests/bpf/unpriv_helpers.c | 1 - > 18 files changed, 12 insertions(+), 12 deletions(-) > > -- > 2.34.1 >
