On Mon, 2024-07-22 at 21:26 +0200, Jakub Sitnicki wrote: > On Mon, Jul 22, 2024 at 03:07 PM +02, Michal Luczaj wrote: [...] > > One more thing: I've noticed changes in sockmap_helpers.h don't trigger > > test_progs rebuild (seems to be the case for all .h in prog_tests/). No > > idea if this is the right approach, but adding > > "$(TRUNNER_TESTS_DIR)/sockmap_helpers.h" to TRUNNER_EXTRA_SOURCES in > > selftests/bpf/Makefile does the trick. > > CC'ed BPF selftests reviewers in case they'd like to chip in. Are you sure this is reproducible? I tried the following: $ make clean $ make -j test_progs $ touch prog_tests/sockmap_helpers.h $ make -j test_progs And I see the following files being remade: TEST-OBJ [test_progs] sockmap_basic.test.o TEST-OBJ [test_progs] sockmap_listen.test.o TEST-OBJ [test_progs] verifier.test.o BINARY test_progs (Although, there are a few other files, that probably should not be remade, need to look into it). Also, here is some debug output: $ make -j24 --print-data-base | grep "sockmap_basic.test.o:" | tr ' ' '\n' | grep '\(:\|sockmap_helpers.h\)' /home/eddy/work/bpf-next/tools/testing/selftests/bpf/cpuv4/sockmap_basic.test.o: /home/eddy/work/bpf-next/tools/testing/selftests/bpf/prog_tests/sockmap_helpers.h /home/eddy/work/bpf-next/tools/testing/selftests/bpf/sockmap_basic.test.o: /home/eddy/work/bpf-next/tools/testing/selftests/bpf/prog_tests/sockmap_helpers.h /home/eddy/work/bpf-next/tools/testing/selftests/bpf/no_alu32/sockmap_basic.test.o: /home/eddy/work/bpf-next/tools/testing/selftests/bpf/prog_tests/sockmap_helpers.h [...]
