On 7/9/24 11:48, Jakub Sitnicki wrote: > On Sun, Jul 07, 2024 at 11:28 PM +02, Michal Luczaj wrote: >> Function ignores the AF_INET socket type argument, SOCK_DGRAM is hardcoded. >> Fix to respect the argument provided. >> >> Suggested-by: Jakub Sitnicki <jakub@xxxxxxxxxxxxxx> >> Signed-off-by: Michal Luczaj <mhal@xxxxxxx> >> --- > > Thanks for the fixup. > > Reviewed-by: Jakub Sitnicki <jakub@xxxxxxxxxxxxxx> Ugh, my commit message is wrong. Change is for socketpair(AF_UNIX), not inet_socketpair(). Sorry, will fix. Speaking of fixups, do you want it tagged with Fixes: 75e0e27db6cf ("selftest/bpf: Change udp to inet in some function names")? And looking at that commit[1], inet_unix_redir_to_connected() has its @type ignored, too. Same treatment? [1] https://lore.kernel.org/netdev/20210816190327.2739291-5-jiang.wang@xxxxxxxxxxxxx/