On Fri, Jul 19, 2024 at 2:37 AM Yunsheng Lin <linyunsheng@xxxxxxxxxx> wrote: > > Currently the page_frag API is returning 'virtual address' > or 'va' when allocing and expecting 'virtual address' or > 'va' as input when freeing. > > As we are about to support new use cases that the caller > need to deal with 'struct page' or need to deal with both > 'va' and 'struct page'. In order to differentiate the API > handling between 'va' and 'struct page', add '_va' suffix > to the corresponding API mirroring the page_pool_alloc_va() > API of the page_pool. So that callers expecting to deal with > va, page or both va and page may call page_frag_alloc_va*, > page_frag_alloc_pg*, or page_frag_alloc* API accordingly. > > CC: Alexander Duyck <alexander.duyck@xxxxxxxxx> > Signed-off-by: Yunsheng Lin <linyunsheng@xxxxxxxxxx> > Reviewed-by: Subbaraya Sundeep <sbhatta@xxxxxxxxxxx> Rather than renaming the existing API I would rather see this follow the same approach as we use with the other memory subsystem functions. A specific example being that with free_page it is essentially passed a virtual address, while the double underscore version is passed a page. I would be more okay with us renaming the double underscore version of any functions we might have to address that rather than renaming all the functions with "va". In general I would say this patch is adding no value as what it is doing is essentially pushing the primary users of this API to change to support use cases that won't impact most of them. It is just creating a ton of noise in terms of changes with no added value so we can reuse the function names.
