On Fri, Jul 12, 2024 at 6:52 AM Jiri Olsa <jolsa@xxxxxxxxxx> wrote: > > After discussing with Arnd [1] it's preferable to change uretprobe > syscall number to 467 to omit the merge conflict with xattrat syscalls. > > Also changing the ABI to 'common' which will ease up the global > scripts/syscall.tbl management. One consequence is we generate uretprobe > syscall numbers for ABIs that do not support uretprobe syscall, but the > syscall still returns -ENOSYS when called in that ABI. > > [1] https://lore.kernel.org/lkml/784a34e5-4654-44c9-9c07-f9f4ffd952a0@xxxxxxxxxxxxxxxx/ > > Fixes: 190fec72df4a ("uprobe: Wire up uretprobe system call") > Suggested-by: Arnd Bergmann <arnd@xxxxxxxx> > Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx> > --- > arch/x86/entry/syscalls/syscall_64.tbl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > sure, why not Acked-by: Andrii Nakryiko <andrii@xxxxxxxxxx> > diff --git a/arch/x86/entry/syscalls/syscall_64.tbl b/arch/x86/entry/syscalls/syscall_64.tbl > index 6452c2ec469a..dabf1982de6d 100644 > --- a/arch/x86/entry/syscalls/syscall_64.tbl > +++ b/arch/x86/entry/syscalls/syscall_64.tbl > @@ -384,7 +384,7 @@ > 460 common lsm_set_self_attr sys_lsm_set_self_attr > 461 common lsm_list_modules sys_lsm_list_modules > 462 common mseal sys_mseal > -463 64 uretprobe sys_uretprobe > +467 common uretprobe sys_uretprobe > > # > # Due to a historical design error, certain syscalls are numbered differently > -- > 2.45.2 >
