On 7/10/24 8:16 AM, Daniel Borkmann wrote:
On 7/10/24 4:16 PM, Sebastian Andrzej Siewior wrote:The syzbot reported that the lwt_seg6 related BPF ops can be invoked via bpf_test_run() without without entering input_action_end_bpf() first. Martin KaFai Lau said that self test for BPF_PROG_TYPE_LWT_SEG6LOCAL probably didn't work since it was introduced in commit 04d4b274e2a ("ipv6: sr: Add seg6local action End.BPF"). The reason is that the per-CPU variable seg6_bpf_srh_states::srh is never assigned in the self test case but each BPF function expects it. Remove test_run for BPF_PROG_TYPE_LWT_SEG6LOCAL. Suggested-by: Martin KaFai Lau <martin.lau@xxxxxxxxx> Reported-by: syzbot+608a2acde8c5a101d07d@xxxxxxxxxxxxxxxxxxxxxxxxx Fixes: d1542d4ae4df ("seg6: Use nested-BH locking for seg6_bpf_srh_states.")We can also add in addition for reference: Fixes: 004d4b274e2a ("ipv6: sr: Add seg6local action End.BPF")
Added the Fixes tag before applying. Thanks!
